src/dev/peerat/backend/Configuration.java

@@ -47,22 +47,16 @@ public class Configuration {
 		System.out.println("Config on " + _file.getAbsolutePath());
 	}
 
-	public <T> Configuration addDefaultValue(String name, T value) throws Exception{
-		if(value == null) throw new IllegalArgumentException("Value cannot be null");
-		Field field = getClass().getDeclaredField(name);
-		field.setAccessible(true);
-		field.set(this, value);
-		return this;
-	}
-
 	public void load() throws Exception {
-		if(!this._file.exists()) return;
+		if (!this._file.exists())
+			return;
 		BufferedReader reader = new BufferedReader(new FileReader(this._file));
 		String line;
 		while ((line = reader.readLine()) != null) {
 			String[] split = line.split("=");
 			Field field = getClass().getDeclaredField(split[0]);
-			if(field == null) continue;
+			if (field == null)
+				continue;
 			field.setAccessible(true);
 			injectValue(field, split[1]);
 		}
@@ -118,7 +112,8 @@ public class Configuration {
 		BufferedWriter writer = new BufferedWriter(new FileWriter(_file));
 		for (Field field : fields) {
 			field.setAccessible(true);
-			if(field.getName().startsWith("_")) continue;
+			if (field.getName().startsWith("_"))
+				continue;
 			Object value = field.get(this);
 			writer.write(field.getName() + "=" + value);
 		}
@@ -171,6 +166,8 @@ public class Configuration {
 	}
 
 	public String getUsersFiles() {
+		if (users_files == null || users_files.trim().isEmpty())
+			users_files = "/tmp/users_files";
 		return users_files;
 	}
 	

src/dev/peerat/backend/Main.java

@@ -9,6 +9,7 @@ import java.util.regex.Matcher;
 import dev.peerat.backend.model.Completion;
 import dev.peerat.backend.model.Group;
 import dev.peerat.backend.model.PeerAtUser;
+import dev.peerat.backend.model.Player;
 import dev.peerat.backend.repository.DatabaseRepository;
 import dev.peerat.backend.routes.BadgeDetails;
 import dev.peerat.backend.routes.ChapterElement;
@@ -41,8 +42,7 @@ import dev.peerat.framework.Router;
 
 public class Main{
 	public static void main(String[] args) throws Exception{
-		Configuration config = new Configuration("config.txt")
-				.addDefaultValue("users_files", "/tmp/users_files");
+		Configuration config = new Configuration("config.txt");
 		config.load();
 
 		Class.forName("com.mysql.cj.jdbc.Driver");
@@ -87,7 +87,7 @@ public class Main{
 	}
 
 	private static void initRoutes(Router<PeerAtUser> router, DatabaseRepository repo, Configuration config){
-		Map<String, Integer> playersWaiting = new HashMap<>();
+		Map<Player, Integer> playersWaiting = new HashMap<>();
 		router.register(new Register(repo, playersWaiting));
 		router.register(new MailConfirmation(repo, router, config.getUsersFiles(), config.getGitToken(), playersWaiting));
 		router.register(new Login(repo, router));

src/dev/peerat/backend/routes/admins/DynamicLogs.java

@@ -4,7 +4,6 @@ import java.util.regex.Matcher;
 
 import org.json.simple.JSONObject;
 
-import dev.peerat.backend.bonus.extract.RouteDoc;
 import dev.peerat.backend.model.PeerAtUser;
 import dev.peerat.backend.repository.DatabaseRepository;
 import dev.peerat.framework.Context;
@@ -25,10 +24,7 @@ public class DynamicLogs implements Response{
 		this.locker = locker;
 	}
 
-	@RouteDoc(path = "/admin/logs", responseCode = 200, responseDescription = "L'utilisateur peux voir les logs en directe")
-	@RouteDoc(responseCode = 401, responseDescription = "L'utilisateur n'a pas accès à cette ressource")
-
-	@Route(path = "^/admin/logs$", websocket = true)
+	@Route(path = "^/admin/logs$", needLogin = true, websocket = true)
 	public void exec(Matcher matcher, Context context, HttpReader reader, HttpWriter writer) throws Exception {
 		//check if admin
 		
@@ -37,7 +33,6 @@ public class DynamicLogs implements Response{
 		locker.init(key);
 		try {
 			while(!reader.isClosed()){
-				locker.lock(key);
 				Context instance = locker.getValue(key);
 				JSONObject json = new JSONObject();
 				json.put("logged", instance.isLogged());
@@ -48,6 +43,7 @@ public class DynamicLogs implements Response{
 				
 				writer.write(json.toJSONString());
 				writer.flush();
+				locker.lock(key);
 			}
 		}catch(Exception e){
 			e.printStackTrace();

src/dev/peerat/backend/routes/users/MailConfirmation.java

@@ -23,6 +23,7 @@ import org.json.simple.JSONObject;
 
 import dev.peerat.backend.bonus.extract.RouteDoc;
 import dev.peerat.backend.model.PeerAtUser;
+import dev.peerat.backend.model.Player;
 import dev.peerat.backend.repository.DatabaseRepository;
 import dev.peerat.backend.utils.FormResponse;
 import dev.peerat.framework.Context;
@@ -39,14 +40,14 @@ public class MailConfirmation extends FormResponse {
 	private KeyPairGenerator generator;
 	private Encoder encoder;
 	private String gitToken;
-	private Map<String, Integer> playersWaiting;
+	private Map<Player, Integer> playersWaiting;
 
 	public MailConfirmation(
 			DatabaseRepository databaseRepo,
 			Router<PeerAtUser> router,
 			String initUsersFilesPath,
 			String gitToken,
-			Map<String, Integer> playersWaiting){
+			Map<Player, Integer> playersWaiting){
 		this.databaseRepo = databaseRepo;
 		this.router = router;
 		usersFilesPath = initUsersFilesPath;
@@ -71,48 +72,53 @@ public class MailConfirmation extends FormResponse {
 			return;
 		}
 		JSONObject json = json(reader);
-		if(!areValids("email","code","pseudo","firstname","lastname","passwd")){
+		if(!areValids("email","code","passwd")){
 			context.response(400);
 			return;
 		}
 		String email = (String) json.get("email");
-		int code = (int) json.get("code");
-		String pseudo = (String) json.get("pseudo");
-		String firstname = (String) json.get("firstname");
-		String lastname = (String) json.get("lastnae");
 		String password = (String) json.get("passwd");
+		int code = (int) json.get("code");
 		
-		Integer checkCode = playersWaiting.get(email);
-		if(checkCode == null){
-			context.response(400);
-			return;
-		}
-		if(code == checkCode.intValue()){
-			playersWaiting.remove(email);
-			int id = databaseRepo.register(pseudo, email, password, firstname, lastname, "", "", "");
-			if(id >= 0){
-				createFolderToSaveSourceCode(pseudo);
-				generateGitKey(email, pseudo, password);
+		Player newPlayer = getPlayerFromEmail(email);
+		if (newPlayer != null && code == playersWaiting.get(newPlayer)){
+			playersWaiting.remove(newPlayer);
+			String pseudo = newPlayer.getPseudo();
+			int id;
+			if ((id = databaseRepo.register(pseudo, email, password, newPlayer.getFirstname(), newPlayer.getLastname(), "", "", "")) >= 0) {
 				context.response(200,
 						"Access-Control-Expose-Headers: Authorization",
 						"Authorization: Bearer " + this.router.createAuthUser(new PeerAtUser(id)));
+				createFolderToSaveSourceCode(pseudo);
+				generateGitKey(email, pseudo, password);
+				return;
 			} else {
 				context.response(400);
 				JSONObject error = new JSONObject();
 				error.put("username_valid", pseudo);
 				error.put("email_valid", email);
 				writer.write(error.toJSONString());
+				return;
+			}
 		}
-		}else{
 		context.response(400);
 	}
-	}
 
 	private void createFolderToSaveSourceCode(String pseudo) throws IOException {
 
 		Files.createDirectories(Paths.get(String.format("%s/%s", usersFilesPath, pseudo)));
 	}
 	
+	private Player getPlayerFromEmail(String email) {
+		Player toMatch = new Player(email);
+		for (Player p: playersWaiting.keySet()) {
+			if (p.equals(toMatch)) {
+				return p;
+			}
+		}
+		return null;
+	}
+	
 	private String generateGitKey(String email, String pseudo, String password) throws Exception{
 		KeyPair pair = generator.generateKeyPair(); //doit être unique ???
 		

src/dev/peerat/backend/routes/users/Register.java

@@ -9,6 +9,8 @@ import java.util.regex.Matcher;
 import org.json.simple.JSONObject;
 
 import dev.peerat.backend.bonus.extract.RouteDoc;
+import dev.peerat.backend.model.PeerAtUser;
+import dev.peerat.backend.model.Player;
 import dev.peerat.backend.repository.DatabaseRepository;
 import dev.peerat.backend.utils.FormResponse;
 import dev.peerat.framework.Context;
@@ -19,9 +21,9 @@ import dev.peerat.framework.Route;
 public class Register extends FormResponse {
 
 	private DatabaseRepository databaseRepo;
-	private Map<String, Integer> playersWaiting;
+	private Map<Player, Integer> playersWaiting;
 
-	public Register(DatabaseRepository databaseRepo, Map<String, Integer> playersWaiting){
+	public Register(DatabaseRepository databaseRepo, Map<Player, Integer> playersWaiting){
 		this.databaseRepo = databaseRepo;
 		this.playersWaiting = playersWaiting;
 	}
@@ -37,20 +39,26 @@ public class Register extends FormResponse {
 			return;
 		}
 		JSONObject json = json(reader);
-		if(!areValids("email")){
+		if(!areValids("pseudo","email","firstname","lastname")){
 			context.response(400);
 			return;
 		}
 		
+		String pseudo = (String) json.get("pseudo");
 		String email = (String) json.get("email");
+		String firstname = (String) json.get("firstname");
+		String lastname = (String) json.get("lastname");
 
+		boolean pseudoAvailable = databaseRepo.checkPseudoAvailability(pseudo);
 		boolean emailAvailable = databaseRepo.checkEmailAvailability(email);
-		if(emailAvailable){
-			playersWaiting.put(email, codeGenerator());
+		if(pseudoAvailable && emailAvailable){
+			Player player = new Player(pseudo, email, firstname, lastname);
+			playersWaiting.put(player, codeGenerator());
 			context.response(200);
 		}else{
 			context.response(400);
 			JSONObject error = new JSONObject();
+			error.put("username_valid", pseudoAvailable);
 			error.put("email_valid", emailAvailable);
 			writer.write(error.toJSONString());
 		}

src/dev/peerat/backend/utils/Mail.java

@@ -24,6 +24,7 @@ public class Mail {
 		props.put("mail.smtp.starttls.enable", "true");
 		
 		Authenticator auth = new Authenticator() {
+			//override the getPasswordAuthentication method
 			protected PasswordAuthentication getPasswordAuthentication() {
 				return new PasswordAuthentication(initUsername, initPassword);
 			}